From 803a0a6d328cfa86f5ed7a581e7478c307e7f1cb Mon Sep 17 00:00:00 2001
From: dcarrillo <daniel.carrillo@gmail.com>
Date: Sat, 11 Apr 2026 18:43:35 +0200
Subject: [PATCH] feat: set proper default for check settings (#2)

---
 README.md             | 20 +++++++++++++++++++-
 src/config/config.ts  |  8 ++++----
 wrangler.example.toml |  2 +-
 3 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index e048ce4..8ec9542 100644
--- a/README.md
+++ b/README.md
@@ -122,14 +122,32 @@ atalaya/
 
 ### Settings
 
+Default values:
+
 ```yaml
 settings:
-  default_retries: 3 # Retry attempts on failure
+  title: 'Atalaya Uptime Monitor' # Status page title
+  default_retries: 2 # Retry attempts on failure
   default_retry_delay_ms: 1000 # Delay between retries
   default_timeout_ms: 5000 # Request timeout
   default_failure_threshold: 2 # Failures before alerting
 ```
 
+### Per-Monitor Overrides
+
+Each monitor can override the global default_* settings:
+
+```yaml
+- name: 'critical-api'
+  type: http
+  target: 'https://api.example.com/health'
+  timeout_ms: 10000 # Override global check_timeout_ms
+  retries: 3 # Override global check_retries
+  retry_delay_ms: 500 # Override global check_retry_delay_ms
+  failure_threshold: 1 # Override global check_failure_threshold
+  alerts: ['alert']
+```
+
 ### Monitor Types
 
 **HTTP**
diff --git a/src/config/config.ts b/src/config/config.ts
index 6f5878a..82e60df 100644
--- a/src/config/config.ts
+++ b/src/config/config.ts
@@ -13,10 +13,10 @@ function interpolateEnv(content: string, envVars: Record<string, string | undefi
 
 function applyDefaults(raw: RawYamlConfig): Config {
   const settings: Settings = {
-    defaultRetries: raw.settings?.default_retries ?? 0,
-    defaultRetryDelayMs: raw.settings?.default_retry_delay_ms ?? 0,
-    defaultTimeoutMs: raw.settings?.default_timeout_ms ?? 0,
-    defaultFailureThreshold: raw.settings?.default_failure_threshold ?? 0,
+    defaultRetries: raw.settings?.default_retries ?? 2,
+    defaultRetryDelayMs: raw.settings?.default_retry_delay_ms ?? 1000,
+    defaultTimeoutMs: raw.settings?.default_timeout_ms ?? 5000,
+    defaultFailureThreshold: raw.settings?.default_failure_threshold ?? 2,
     title: raw.settings?.title ?? 'Atalaya Uptime Monitor',
   };
 
diff --git a/wrangler.example.toml b/wrangler.example.toml
index fd7f1f4..a862306 100644
--- a/wrangler.example.toml
+++ b/wrangler.example.toml
@@ -30,7 +30,7 @@ new_sqlite_classes = ["RegionalChecker"]
 MONITORS_CONFIG = """
 settings:
   title: "Atalaya Uptime Monitor"
-  default_retries: 3
+  default_retries: 2
   default_retry_delay_ms: 1000
   default_timeout_ms: 5000
   default_failure_threshold: 2