dcarrillo/prezto
1
0
Fork 0
mirror of https://github.com/dcarrillo/prezto.git synced 2024-12-22 17:28:01 +00:00
Code Issues Releases Wiki Activity

[git] Fix 'git-hub-shorten-url' helper

Browse Source 
Changes:
- Use git.io over 'https'
- Add extra check to conform to *.github.com URLs
- Use built-in _urls function for completion
- Update readme with GitHub blog URL
This commit is contained in:
Indrajit Raychaudhuri 2017-07-07 00:02:13 -05:00 committed by Kaleb Elwert
parent 7d5beeab51
commit e6136a517b
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/git/README.md
View File

@ -317,7 +317,7 @@ Functions
- `git-commit-lost` lists lost commits. - `git-commit-lost` lists lost commits.
- `git-dir` displays the path to the Git directory. - `git-dir` displays the path to the Git directory.
- `git-hub-browse` opens the [GitHub][3] repository in the default browser. - `git-hub-browse` opens the [GitHub][3] repository in the default browser.
- `git-hub-shorten-url` shortens GitHub URLs. - `git-hub-shorten-url` shortens [GitHub URLs][10].
- `git-info` exposes repository information via the `$git_info` associative - `git-info` exposes repository information via the `$git_info` associative
array. array.
- `git-root` displays the path to the working tree root. - `git-root` displays the path to the working tree root.
@ -422,3 +422,4 @@ Authors
[7]: https://github.com/sorin-ionescu/prezto/issues/219 [7]: https://github.com/sorin-ionescu/prezto/issues/219
[8]: http://www.kernel.org/pub/software/scm/git/docs/git-log.html [8]: http://www.kernel.org/pub/software/scm/git/docs/git-log.html
[9]: https://getgb.io/ [9]: https://getgb.io/
[10]: https://github.com/blog/985-git-io-github-url-shortener

2
modules/git/functions/_git-hub-shorten-url
View File

@ -8,4 +8,4 @@
# Sorin Ionescu <sorin.ionescu@gmail.com> # Sorin Ionescu <sorin.ionescu@gmail.com>
# #
_arguments '1:url:' && return 0 _arguments '::GitHub URL:_urls' && return 0

6
modules/git/functions/git-hub-shorten-url
View File

@ -13,12 +13,12 @@ if [[ "$url" == '-' ]]; then
read url <&0 read url <&0
fi fi
if [[ -z "$url" ]]; then if [[ -z "$url" || ! "$url" =~ ^https?:\/\/.*github.com\/ ]]; then
print "usage: $0 [ url | - ]" >&2 print "usage: $0 [ url | - ] ; must be a github.com URL" >&2
fi fi
if (( $+commands[curl] )); then if (( $+commands[curl] )); then
curl -s -i 'http://git.io' -F "url=$url" | sed -n 's/^Location: //p' curl -s -i 'https://git.io' -F "url=$url" | sed -n 's/^Location: //p'
else else
print "$0: command not found: curl" >&2 print "$0: command not found: curl" >&2
fi fi