Return 404 when the dns domain has any path different than /

This commit is contained in:
Daniel Carrillo 2024-05-12 19:24:10 +02:00
parent b57beded8f
commit 789cc6939e
Signed by: dcarrillo
GPG Key ID: E4CD5C09DAED6E16
3 changed files with 16 additions and 3 deletions

View File

@ -32,7 +32,7 @@ Take a look at [ifconfig.es](https://ifconfig.es) a live site using `whatismyip`
Get your public IP easily from the command line: Get your public IP easily from the command line:
```text ```bash
curl ifconfig.es curl ifconfig.es
127.0.0.1 127.0.0.1
@ -42,7 +42,7 @@ curl -6 ifconfig.es
Get the IP of your DNS provider: Get the IP of your DNS provider:
```text ```bash
curl -L dns.ifconfig.es curl -L dns.ifconfig.es
2a04:e4c0:47::67 (Spain / OPENDNS) 2a04:e4c0:47::67 (Spain / OPENDNS)
``` ```

View File

@ -31,7 +31,7 @@ func GetDNSDiscoveryHandler(store *cache.Cache, domain string, redirectPort stri
return return
} }
if ctx.Request.Host == domain { if ctx.Request.Host == domain && ctx.Request.URL.Path == "/" {
ctx.Redirect(http.StatusFound, fmt.Sprintf("http://%s.%s%s", uuid.New().String(), domain, redirectPort)) ctx.Redirect(http.StatusFound, fmt.Sprintf("http://%s.%s%s", uuid.New().String(), domain, redirectPort))
ctx.Abort() ctx.Abort()
return return

View File

@ -33,6 +33,19 @@ func TestGetDNSDiscoveryHandler(t *testing.T) {
assert.Equal(t, testIP.ipv4+"\n", w.Body.String()) assert.Equal(t, testIP.ipv4+"\n", w.Body.String())
}) })
t.Run("return 404 if there is a path", func(t *testing.T) {
req, _ := http.NewRequest("GET", "/path", nil)
req.Host = domain
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = req
handler(c)
app.ServeHTTP(w, req)
assert.Equal(t, http.StatusNotFound, w.Code)
})
t.Run("redirects if host is domain", func(t *testing.T) { t.Run("redirects if host is domain", func(t *testing.T) {
req, _ := http.NewRequest("GET", "/", nil) req, _ := http.NewRequest("GET", "/", nil)
req.Host = domain req.Host = domain