mirror of
https://github.com/dcarrillo/whatismyip.git
synced 2026-07-23 22:45:46 +00:00
dcarrillo
49ffcadb0a
High (behavioral bugs):
- service.Geo: add RLock on lookups, handle Reload error, keep old DBs on failure
- models.GeoDB.Reload: open new DBs before closing old ones (no reader gap)
- router: guard nil geo records (404 instead of 500) in geo.go, generic.go, dns.go
- router/port_scanner: reject undetermined client IPs (nil->localhost dial)
- internal/httputils: fix access log date layout (02/Jan/2006, not literal Nov)
- server/quic: log.Printf instead of log.Fatal in request handler
Medium:
- server/*: 10s shutdown timeout; SIGTERM drains servers before closing geo DBs
- httputils: Clone() request headers instead of mutating the live map; strings.Builder
- setting/app: handle all os.Stat errors; fix "truster" typos; use errors.New;
remove dead Token field
- cmd: errors.Is for sentinel checks; os.Stderr; log.Fatal instead of panic;
pass http.Handler by value (not pointer-to-interface)
- resolver: validate config at startup (pre-parse RRs, validate IPs); check WriteMsg
errors; Setup returns error
Low:
- .golangci.yaml: enable errcheck, govet, errorlint; fix all resulting findings
- server/tls: explicit TLSConfig{MinVersion: tls.VersionTLS12}
- router/dns: label-exact vhost suffix check, strip port; template.Must
- models: errors.Join instead of %s on []error
- service/geo_test: race-regression test (concurrent lookups during Reload)
- README: Go >= 1.25; fix latent test bug (store.Add->Set in dns_test.go)
62 lines
1.4 KiB
Go
62 lines
1.4 KiB
Go
package httputils
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestHeaderToString(t *testing.T) {
|
|
expected := `Header1: One
|
|
Header2: 2
|
|
Header2: Two
|
|
Header3: Three
|
|
`
|
|
header := http.Header{
|
|
"Header2": []string{"2", "Two"},
|
|
"Header1": []string{"One"},
|
|
"Header3": []string{"Three"},
|
|
}
|
|
|
|
assert.Equal(t, expected, HeadersToSortedString(header))
|
|
}
|
|
|
|
func TestGetLogFormatter(t *testing.T) {
|
|
expected := "127.0.0.1 - [15/Jul/2022:10:30:00 +0000] \"GET / HTTP/1.1\" 200 100 1000 local \"golang test 1.0\" \"1.1.1.1, 2.2.2.2\" \"-\"\n"
|
|
|
|
h := http.Header{}
|
|
h.Set("User-Agent", "golang test 1.0")
|
|
h.Set("Referer", "local")
|
|
h.Set("X-Forwarded-For", "1.1.1.1, 2.2.2.2")
|
|
|
|
r := http.Request{
|
|
Proto: "HTTP/1.1",
|
|
Header: h,
|
|
}
|
|
|
|
p := gin.LogFormatterParams{
|
|
ClientIP: "127.0.0.1",
|
|
TimeStamp: time.Date(2022, time.July, 15, 10, 30, 0, 0, time.UTC),
|
|
Method: "GET",
|
|
Path: "/",
|
|
StatusCode: 200,
|
|
BodySize: 100,
|
|
Latency: 1000,
|
|
ErrorMessage: "",
|
|
Request: &r,
|
|
}
|
|
|
|
assert.Equal(t, expected, GetLogFormatter(p))
|
|
}
|
|
|
|
func TestNormalizeLog(t *testing.T) {
|
|
assert.Equal(t, "-", normalizeLog(""))
|
|
assert.Equal(t, "string", normalizeLog("string"))
|
|
assert.Equal(t, "-", normalizeLog([]string{}))
|
|
assert.Equal(t, "1.1.1.1", normalizeLog([]string{"1.1.1.1"}))
|
|
assert.Equal(t, "1.1.1.1, 2.2.2.2", normalizeLog([]string{"1.1.1.1", "2.2.2.2"}))
|
|
}
|