mirror of
https://github.com/dcarrillo/whatismyip.git
synced 2026-07-22 11:04:46 +00:00
dcarrillo
49ffcadb0a
High (behavioral bugs):
- service.Geo: add RLock on lookups, handle Reload error, keep old DBs on failure
- models.GeoDB.Reload: open new DBs before closing old ones (no reader gap)
- router: guard nil geo records (404 instead of 500) in geo.go, generic.go, dns.go
- router/port_scanner: reject undetermined client IPs (nil->localhost dial)
- internal/httputils: fix access log date layout (02/Jan/2006, not literal Nov)
- server/quic: log.Printf instead of log.Fatal in request handler
Medium:
- server/*: 10s shutdown timeout; SIGTERM drains servers before closing geo DBs
- httputils: Clone() request headers instead of mutating the live map; strings.Builder
- setting/app: handle all os.Stat errors; fix "truster" typos; use errors.New;
remove dead Token field
- cmd: errors.Is for sentinel checks; os.Stderr; log.Fatal instead of panic;
pass http.Handler by value (not pointer-to-interface)
- resolver: validate config at startup (pre-parse RRs, validate IPs); check WriteMsg
errors; Setup returns error
Low:
- .golangci.yaml: enable errcheck, govet, errorlint; fix all resulting findings
- server/tls: explicit TLSConfig{MinVersion: tls.VersionTLS12}
- router/dns: label-exact vhost suffix check, strip port; template.Must
- models: errors.Join instead of %s on []error
- service/geo_test: race-regression test (concurrent lookups during Reload)
- README: Go >= 1.25; fix latent test bug (store.Add->Set in dns_test.go)
49 lines
1010 B
Go
49 lines
1010 B
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"log"
|
|
"net/http"
|
|
|
|
"github.com/dcarrillo/whatismyip/internal/setting"
|
|
)
|
|
|
|
type TCP struct {
|
|
server *http.Server
|
|
handler http.Handler
|
|
ctx context.Context
|
|
}
|
|
|
|
func NewTCPServer(ctx context.Context, handler http.Handler) *TCP {
|
|
return &TCP{
|
|
handler: handler,
|
|
ctx: ctx,
|
|
}
|
|
}
|
|
|
|
func (t *TCP) Start() {
|
|
t.server = &http.Server{
|
|
Addr: setting.App.BindAddress,
|
|
Handler: t.handler,
|
|
ReadTimeout: setting.App.Server.ReadTimeout,
|
|
WriteTimeout: setting.App.Server.WriteTimeout,
|
|
}
|
|
|
|
log.Printf("Starting TCP server listening on %s", setting.App.BindAddress)
|
|
go func() {
|
|
if err := t.server.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
|
|
log.Fatal(err)
|
|
}
|
|
}()
|
|
}
|
|
|
|
func (t *TCP) Stop() {
|
|
log.Print("Stopping TCP server...")
|
|
ctx, cancel := context.WithTimeout(t.ctx, shutdownTimeout)
|
|
defer cancel()
|
|
if err := t.server.Shutdown(ctx); err != nil {
|
|
log.Printf("TCP server forced to shutdown: %s", err)
|
|
}
|
|
}
|