Merge pull request #7 from dcarrillo/linting

Add linting at github actions

.github/workflows/main.yml

@@ -14,6 +14,12 @@ jobs:
     steps:
       - uses: actions/checkout@v1
 
+      - name: shellcheck
+        uses: azohra/shell-linter@v0.1.0
+
+      - name: hadolint
+        uses: brpaz/hadolint-action@master
+
       - name: Build image
         run: ./build.sh
 

Dockerfile

@@ -6,7 +6,8 @@ ARG ARG_NGX_GEOIP2_VERSION
 ENV NGINX_VERSION $ARG_NGINX_VERSION
 ENV NGX_GEOIP2_VERSION $ARG_NGX_GEOIP2_VERSION
 
-RUN CONFIG="\
+# hadolint ignore=DL3018,DL3003,SC2086
+RUN CONFIG=" \
         --add-module=/tmp/ngx_http_geoip2_module-$NGX_GEOIP2_VERSION \
         --with-stream \
         --with-http_ssl_module \

build.sh

@@ -2,6 +2,7 @@
 
 set -e
 
+# shellcheck disable=SC1090
 . "$(dirname "$0")"/conf.env
 
 while [ $# -gt 0 ]; do

tests/test.sh

@@ -6,11 +6,13 @@ if [ x"$DEBUG" = xtrue ]; then
     set -x
 fi
 
+# shellcheck disable=SC2039
 trap _catch_err ERR
 trap _cleanup EXIT
 
 ALPINE_VERSION="alpine:3.11"
 LOCAL_DIR="$(cd "$(dirname "$0")" ; pwd -P)"
+# shellcheck disable=SC1090
 . "$LOCAL_DIR"/../conf.env
 
 TMP_DIR=$(mktemp -d)