mirror of
https://github.com/dcarrillo/whatismyip.git
synced 2026-07-23 19:15:46 +00:00
dcarrillo
49ffcadb0a
High (behavioral bugs):
- service.Geo: add RLock on lookups, handle Reload error, keep old DBs on failure
- models.GeoDB.Reload: open new DBs before closing old ones (no reader gap)
- router: guard nil geo records (404 instead of 500) in geo.go, generic.go, dns.go
- router/port_scanner: reject undetermined client IPs (nil->localhost dial)
- internal/httputils: fix access log date layout (02/Jan/2006, not literal Nov)
- server/quic: log.Printf instead of log.Fatal in request handler
Medium:
- server/*: 10s shutdown timeout; SIGTERM drains servers before closing geo DBs
- httputils: Clone() request headers instead of mutating the live map; strings.Builder
- setting/app: handle all os.Stat errors; fix "truster" typos; use errors.New;
remove dead Token field
- cmd: errors.Is for sentinel checks; os.Stderr; log.Fatal instead of panic;
pass http.Handler by value (not pointer-to-interface)
- resolver: validate config at startup (pre-parse RRs, validate IPs); check WriteMsg
errors; Setup returns error
Low:
- .golangci.yaml: enable errcheck, govet, errorlint; fix all resulting findings
- server/tls: explicit TLSConfig{MinVersion: tls.VersionTLS12}
- router/dns: label-exact vhost suffix check, strip port; template.Must
- models: errors.Join instead of %s on []error
- service/geo_test: race-regression test (concurrent lookups during Reload)
- README: Go >= 1.25; fix latent test bug (store.Add->Set in dns_test.go)
68 lines
1.2 KiB
Go
68 lines
1.2 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
"os"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var geoSvc *Geo
|
|
|
|
func TestMain(m *testing.M) {
|
|
geoSvc, _ = NewGeo(context.Background(), "../test/GeoIP2-City-Test.mmdb", "../test/GeoLite2-ASN-Test.mmdb")
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestCityLookup(t *testing.T) {
|
|
c := geoSvc.LookUpCity(net.ParseIP("error"))
|
|
assert.Nil(t, c)
|
|
|
|
c = geoSvc.LookUpCity(net.ParseIP("1.1.1.1"))
|
|
assert.NotNil(t, c)
|
|
}
|
|
|
|
func TestASNLookup(t *testing.T) {
|
|
a := geoSvc.LookUpASN(net.ParseIP("error"))
|
|
assert.Nil(t, a)
|
|
|
|
a = geoSvc.LookUpASN(net.ParseIP("1.1.1.1"))
|
|
assert.NotNil(t, a)
|
|
}
|
|
|
|
func TestReloadIsSafeForConcurrentLookups(t *testing.T) {
|
|
svc, err := NewGeo(context.Background(), "../test/GeoIP2-City-Test.mmdb", "../test/GeoLite2-ASN-Test.mmdb")
|
|
require.NoError(t, err)
|
|
defer svc.Shutdown()
|
|
|
|
ip := net.ParseIP("81.2.69.192")
|
|
|
|
var wg sync.WaitGroup
|
|
stop := make(chan struct{})
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for {
|
|
select {
|
|
case <-stop:
|
|
return
|
|
default:
|
|
svc.LookUpCity(ip)
|
|
svc.LookUpASN(ip)
|
|
}
|
|
}
|
|
}()
|
|
|
|
for range 100 {
|
|
svc.Reload()
|
|
}
|
|
close(stop)
|
|
wg.Wait()
|
|
|
|
assert.NotNil(t, svc.LookUpCity(ip))
|
|
}
|